diff options
| author | Peter Dettman <peter.dettman@bouncycastle.org> | 2014-03-06 05:32:41 +0400 |
|---|---|---|
| committer | Peter Dettman <peter.dettman@bouncycastle.org> | 2014-03-06 05:32:41 +0400 |
| commit | 1bfc53f8447b4f89c091e0084d08193f9a889efe (patch) | |
| tree | 55463af1665a62d5100eb3e139b3cb0e56b421e9 /core/src/main/java/org | |
| parent | a2ae6797ebe0f28e033db27def52602db0b324f3 (diff) | |
Avoid redundant subtraction
Diffstat (limited to 'core/src/main/java/org')
| -rw-r--r-- | core/src/main/java/org/bouncycastle/crypto/generators/DHKeyGeneratorHelper.java | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/core/src/main/java/org/bouncycastle/crypto/generators/DHKeyGeneratorHelper.java b/core/src/main/java/org/bouncycastle/crypto/generators/DHKeyGeneratorHelper.java index e0d86fc3..d395d5d3 100644 --- a/core/src/main/java/org/bouncycastle/crypto/generators/DHKeyGeneratorHelper.java +++ b/core/src/main/java/org/bouncycastle/crypto/generators/DHKeyGeneratorHelper.java @@ -19,7 +19,6 @@ class DHKeyGeneratorHelper BigInteger calculatePrivate(DHParameters dhParams, SecureRandom random) { - BigInteger p = dhParams.getP(); int limit = dhParams.getL(); if (limit != 0) @@ -34,12 +33,12 @@ class DHKeyGeneratorHelper min = ONE.shiftLeft(m - 1); } - BigInteger max = p.subtract(TWO); BigInteger q = dhParams.getQ(); - if (q != null) + if (q == null) { - max = q.subtract(TWO); + q = dhParams.getP(); } + BigInteger max = q.subtract(TWO); return BigIntegers.createRandomInRange(min, max, random); } |