Deterministic (EC)DSA doesn't need SecureRandom in init

1 files changed, 7 insertions, 2 deletions

diff --git a/core/src/main/java/org/bouncycastle/crypto/tls/TlsDSASigner.java b/core/src/main/java/org/bouncycastle/crypto/tls/TlsDSASigner.java
index f94b701c..caaad59a 100644
--- a/core/src/main/java/org/bouncycastle/crypto/tls/TlsDSASigner.java
+++ b/core/src/main/java/org/bouncycastle/crypto/tls/TlsDSASigner.java
@@ -50,7 +50,7 @@ public abstract class TlsDSASigner
 
     public Signer createSigner(SignatureAndHashAlgorithm algorithm, AsymmetricKeyParameter privateKey)
     {
-        return makeSigner(algorithm, false, true, new ParametersWithRandom(privateKey, this.context.getSecureRandom()));
+        return makeSigner(algorithm, false, true, privateKey);
     }
 
     public Signer createVerifyer(SignatureAndHashAlgorithm algorithm, AsymmetricKeyParameter publicKey)
@@ -58,6 +58,11 @@ public abstract class TlsDSASigner
         return makeSigner(algorithm, false, false, publicKey);
     }
 
+    protected CipherParameters makeInitParameters(boolean forSigning, CipherParameters cp)
+    {
+        return cp;
+    }
+
     protected Signer makeSigner(SignatureAndHashAlgorithm algorithm, boolean raw, boolean forSigning,
         CipherParameters cp)
     {
@@ -77,7 +82,7 @@ public abstract class TlsDSASigner
         Digest d = raw ? new NullDigest() : TlsUtils.createHash(hashAlgorithm);
 
         Signer s = new DSADigestSigner(createDSAImpl(hashAlgorithm), d);
-        s.init(forSigning, cp);
+        s.init(forSigning, makeInitParameters(forSigning, cp));
         return s;
     }