diff options
| author | François Laignel <fengalin@free.fr> | 2020-03-19 21:34:51 +0300 |
|---|---|---|
| committer | Sebastian Dröge <slomo@coaxion.net> | 2020-03-21 21:46:03 +0300 |
| commit | 116cf9bd3c3ea2c809e20fd70049c425e0a1a238 (patch) | |
| tree | 3c5da011b8fc7649d8cf950f797c162389886304 /Cargo.toml | |
| parent | 3c82f7d82e8e095af17d7c0d5bf80396ff92fd14 (diff) | |
threadshare/*src: rework pause/flush_start/flush_stop
This commit fixes several issues with the `Ts*Src` elements.
The pause functions used cancel_task which breaks the Task loop at await
points. For some elements, this implies making sure no item is being lost.
Moreover, cancelling the Task also cancels downstream processing, which
makes it difficult to ensure elements can handle all cases.
This commit reimplements Task::pause which allows completing the running
loop iteration before pausing the loop.
See https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/277#note_439529
In the Paused state, incoming items were rejected by TsAppSrc and DataQueue.
See https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/277#note_438455
- FlushStart must engage items rejection and cancel the Task.
- FlushStop must purge the internal stream & accept items again.
If the task was cancelled, `push_prelude` could set `need_initial_events`
to `true` when the events weren't actually pushed yet.
TsAppSrc used to renew its internal channel which could cause Buffer loss
when transitionning Playing -> Paused -> Playing.
See https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/issues/98
Diffstat (limited to 'Cargo.toml')
0 files changed, 0 insertions, 0 deletions