Fix various new clippy warnings

9 files changed, 11 insertions, 11 deletions

diff --git a/generic/file/src/file_location.rs b/generic/file/src/file_location.rs
index 83fa75d89..266845653 100644
--- a/generic/file/src/file_location.rs
+++ b/generic/file/src/file_location.rs
@@ -74,7 +74,7 @@ impl FileLocation {
             .parent()
             .expect("FileSink::set_location `location` with filename but without a parent")
             .to_owned();
-        if parent_dir.is_relative() && parent_dir.components().next() == None {
+        if parent_dir.is_relative() && parent_dir.components().next().is_none() {
             // `location` only contains the filename
             // need to specify "." for `canonicalize` to resolve the actual path
             parent_dir = PathBuf::from(".");
diff --git a/generic/sodium/examples/decrypt_example.rs b/generic/sodium/examples/decrypt_example.rs
index 301c5443d..f888c96ec 100644
--- a/generic/sodium/examples/decrypt_example.rs
+++ b/generic/sodium/examples/decrypt_example.rs
@@ -53,7 +53,7 @@ struct Keys {
 
 impl Keys {
     fn from_file(file: &Path) -> Result<Self, Box<dyn Error>> {
-        let f = File::open(&file)?;
+        let f = File::open(file)?;
         serde_json::from_reader(f).map_err(From::from)
     }
 }
diff --git a/generic/sodium/examples/encrypt_example.rs b/generic/sodium/examples/encrypt_example.rs
index 8a110a6d3..b94fee5cc 100644
--- a/generic/sodium/examples/encrypt_example.rs
+++ b/generic/sodium/examples/encrypt_example.rs
@@ -57,7 +57,7 @@ struct Keys {
 
 impl Keys {
     fn from_file(file: &Path) -> Result<Self, Box<dyn Error>> {
-        let f = File::open(&file)?;
+        let f = File::open(file)?;
         serde_json::from_reader(f).map_err(From::from)
     }
 }
diff --git a/generic/sodium/tests/decrypter.rs b/generic/sodium/tests/decrypter.rs
index 2e779cda9..43ba194fb 100644
--- a/generic/sodium/tests/decrypter.rs
+++ b/generic/sodium/tests/decrypter.rs
@@ -75,7 +75,7 @@ fn test_pipeline() {
     };
 
     let filesrc = gst::ElementFactory::make("filesrc")
-        .property("location", &input_path.to_str().unwrap())
+        .property("location", input_path.to_str().unwrap())
         .build()
         .unwrap();
 
diff --git a/generic/threadshare/examples/standalone/sink/imp.rs b/generic/threadshare/examples/standalone/sink/imp.rs
index 97a7dae26..dae309315 100644
--- a/generic/threadshare/examples/standalone/sink/imp.rs
+++ b/generic/threadshare/examples/standalone/sink/imp.rs
@@ -610,7 +610,7 @@ impl TestSink {
 
         // Enable backpressure for items
         let (item_sender, item_receiver) = flume::bounded(0);
-        let task_impl = TestSinkTask::new(&*self.obj(), item_receiver);
+        let task_impl = TestSinkTask::new(&self.obj(), item_receiver);
         self.task.prepare(task_impl, context).block_on()?;
 
         *self.item_sender.lock().unwrap() = Some(item_sender);
diff --git a/generic/threadshare/src/jitterbuffer/imp.rs b/generic/threadshare/src/jitterbuffer/imp.rs
index 0b40eb02f..7105720a0 100644
--- a/generic/threadshare/src/jitterbuffer/imp.rs
+++ b/generic/threadshare/src/jitterbuffer/imp.rs
@@ -1259,7 +1259,7 @@ impl JitterBuffer {
 
         self.task
             .prepare(
-                JitterBufferTask::new(&*self.obj(), &self.src_pad_handler, &self.sink_pad_handler),
+                JitterBufferTask::new(&self.obj(), &self.src_pad_handler, &self.sink_pad_handler),
                 context,
             )
             .block_on()?;
diff --git a/generic/threadshare/src/udpsink/imp.rs b/generic/threadshare/src/udpsink/imp.rs
index f9186b33d..cfb0763f3 100644
--- a/generic/threadshare/src/udpsink/imp.rs
+++ b/generic/threadshare/src/udpsink/imp.rs
@@ -840,7 +840,7 @@ impl UdpSink {
         // Enable backpressure for items
         let (item_sender, item_receiver) = flume::bounded(0);
         let (cmd_sender, cmd_receiver) = flume::unbounded();
-        let task_impl = UdpSinkTask::new(&*self.obj(), item_receiver, cmd_receiver);
+        let task_impl = UdpSinkTask::new(&self.obj(), item_receiver, cmd_receiver);
         self.task.prepare(task_impl, context).block_on()?;
 
         *self.item_sender.lock().unwrap() = Some(item_sender);
diff --git a/generic/threadshare/tests/pipeline.rs b/generic/threadshare/tests/pipeline.rs
index 3b8ea46da..caa66ac6c 100644
--- a/generic/threadshare/tests/pipeline.rs
+++ b/generic/threadshare/tests/pipeline.rs
@@ -336,13 +336,13 @@ fn eos() {
         .name("src-eos")
         .property("caps", &caps)
         .property("do-timestamp", true)
-        .property("context", &CONTEXT)
+        .property("context", CONTEXT)
         .build()
         .unwrap();
 
     let queue = gst::ElementFactory::make("ts-queue")
         .name("queue-eos")
-        .property("context", &CONTEXT)
+        .property("context", CONTEXT)
         .build()
         .unwrap();
 
@@ -636,7 +636,7 @@ fn socket_play_null_play() {
     let sink = gst::ElementFactory::make("ts-udpsink")
         .name(format!("sink-{}", TEST).as_str())
         .property("socket", &socket)
-        .property("context", &TEST)
+        .property("context", TEST)
         .property("context-wait", 20u32)
         .build()
         .unwrap();
diff --git a/generic/threadshare/tests/udpsink.rs b/generic/threadshare/tests/udpsink.rs
index 9245ce664..7bb80e01f 100644
--- a/generic/threadshare/tests/udpsink.rs
+++ b/generic/threadshare/tests/udpsink.rs
@@ -100,6 +100,6 @@ fn test_chain() {
         assert!(buf == [42, 43, 44, 45, 0]);
     });
 
-    let buf = gst::Buffer::from_slice(&[42, 43, 44, 45]);
+    let buf = gst::Buffer::from_slice([42, 43, 44, 45]);
     assert!(h.push(buf) == Ok(gst::FlowSuccess::Ok));
 }