diff options
author | Jean-Marc Valin <jmvalin@jmvalin.ca> | 2017-07-15 19:02:38 +0300 |
---|---|---|
committer | Jean-Marc Valin <jmvalin@jmvalin.ca> | 2017-07-15 19:02:38 +0300 |
commit | 32cb34cf4e46cdf36a6527cd77e71dbbb6f2616e (patch) | |
tree | 84821d4433cbba5cbc390429ce18a62d11780452 | |
parent | e74d72baa4ba021d5f41a64ae6ead4d4c5e9741f (diff) |
Fixes nits
-rw-r--r-- | doc/draft-ietf-codec-opus-update.xml | 24 |
1 files changed, 20 insertions, 4 deletions
diff --git a/doc/draft-ietf-codec-opus-update.xml b/doc/draft-ietf-codec-opus-update.xml index 22dda5cf..cfc61eb1 100644 --- a/doc/draft-ietf-codec-opus-update.xml +++ b/doc/draft-ietf-codec-opus-update.xml @@ -11,7 +11,7 @@ <?rfc compact="yes"?> <?rfc subcompact="no"?> <rfc category="std" docName="draft-ietf-codec-opus-update-07" - ipr="trust200902"> + ipr="trust200902" updates="6716"> <front> <title abbrev="Opus Update">Updates to the Opus Audio Codec</title> @@ -51,7 +51,7 @@ <abstract> <t>This document addresses minor issues that were found in the specification - of the Opus audio codec in <xref target="RFC6716">RFC 6716</xref>.</t> + of the Opus audio codec in RFC 6716.</t> </abstract> </front> @@ -61,7 +61,7 @@ implementation of the Opus codec that serves as the specification in <xref target="RFC6716">RFC 6716</xref>. Only issues affecting the decoder are listed here. An up-to-date implementation of the Opus encoder can be found at - https://opus-codec.org/.</t> + <eref target="https://opus-codec.org/"/>.</t> <t> Some of the changes in this document update normative behaviour in a way that requires new test vectors. The English text of the specification is unaffected, only @@ -95,6 +95,7 @@ </t> <figure> <artwork><![CDATA[ +<CODE BEGINS> for( n = 0; n < DECODER_NUM_CHANNELS; n++ ) { ret = silk_init_decoder( &channel_state[ n ] ); } @@ -105,6 +106,7 @@ return ret; } +<CODE ENDS> ]]></artwork> </figure> <t> @@ -122,6 +124,7 @@ </t> <figure> <artwork><![CDATA[ +<CODE BEGINS> /* Padding flag is bit 6 */ if (ch&0x40) { @@ -137,6 +140,7 @@ } while (p==255); - len -= padding; } +<CODE ENDS> ]]></artwork> </figure> <t>This packet parsing issue is limited to reading memory up @@ -173,6 +177,7 @@ </t> <figure> <artwork><![CDATA[ +<CODE BEGINS> ) { silk_resampler_state_struct *S = \ @@ -225,6 +230,7 @@ RESAMPLER_ORDER_FIR_12 * sizeof( opus_int32 ) ); + silk_memcpy( S->sFIR, &buf[ nSamplesIn << 1 ], \ RESAMPLER_ORDER_FIR_12 * sizeof( opus_int16 ) ); } +<CODE ENDS> ]]></artwork> </figure> </section> @@ -239,6 +245,7 @@ RESAMPLER_ORDER_FIR_12 * sizeof( opus_int16 ) ); </t> <figure> <artwork><![CDATA[ +<CODE BEGINS> /* Update AR coefficient */ for( n = 0; n < k; n++ ) { - tmp_QA = Aold_QA[ n ] - MUL32_FRAC_Q( \ @@ -254,6 +261,7 @@ rc_mult2 ), mult2Q); + } + Anew_QA[ n ] = ( opus_int32 )tmp64; } +<CODE ENDS> ]]></artwork> </figure> </section> @@ -268,6 +276,7 @@ rc_mult2 ), mult2Q); </t> <figure> <artwork><![CDATA[ +<CODE BEGINS> /* Keep delta_min distance between the NLSFs */ for( i = 1; i < L; i++ ) - NLSF_Q15[i] = silk_max_int( NLSF_Q15[i], \ @@ -276,6 +285,7 @@ NLSF_Q15[i-1] + NDeltaMin_Q15[i] ); silk_ADD_SAT16( NLSF_Q15[i-1], NDeltaMin_Q15[i] ) ); /* Last NLSF should be no higher than 1 - NDeltaMin[L] */ +<CODE ENDS> ]]></artwork> </figure> @@ -290,6 +300,7 @@ silk_ADD_SAT16( NLSF_Q15[i-1], NDeltaMin_Q15[i] ) ); </t> <figure> <artwork><![CDATA[ +<CODE BEGINS> { opus_val16 lg = ADD16(oldEBands[i+c*m->nbEBands], SHL16((opus_val16)eMeans[i],6)); @@ -297,6 +308,7 @@ silk_ADD_SAT16( NLSF_Q15[i-1], NDeltaMin_Q15[i] ) ); eBands[i+c*m->nbEBands] = PSHR32(celt_exp2(lg),4); } for (;i<m->nbEBands;i++) +<CODE ENDS> ]]></artwork> </figure> </section> @@ -318,6 +330,7 @@ silk_ADD_SAT16( NLSF_Q15[i-1], NDeltaMin_Q15[i] ) ); </t> <figure> <artwork><![CDATA[ +<CODE BEGINS> b = 0; } @@ -346,6 +359,7 @@ n2-n1); tf_change = tf_res[i]; if (i>=m->effEBands) { +<CODE ENDS> ]]></artwork> </figure> @@ -355,6 +369,7 @@ n2-n1); <figure> <artwork><![CDATA[ +<CODE BEGINS> fold_start = lowband_offset; while(M*eBands[--fold_start] > effective_lowband); fold_end = lowband_offset-1; @@ -365,6 +380,7 @@ effective_lowband+N); fold_i = fold_start; do { x_cm |= collapse_masks[fold_i*C+0]; +<CODE ENDS> ]]></artwork> </figure> <t> @@ -426,7 +442,7 @@ effective_lowband+N); </middle> <back> - <references title="References"> + <references title="Normative References"> <?rfc include="http://xml.resource.org/public/rfc/bibxml/reference.RFC.2119.xml"?> <?rfc include="http://xml.resource.org/public/rfc/bibxml/reference.RFC.6716.xml"?> |