Welcome to mirror list, hosted at ThFree Co, Russian Federation.

git.blender.org/blender.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSergey Sharybin <sergey.vfx@gmail.com>2018-03-23 16:32:18 +0300
committerSergey Sharybin <sergey.vfx@gmail.com>2018-03-23 16:38:02 +0300
commitab48e6355dfb279ac70f05637e5533548eea773a (patch)
treee64e99f489b39ed1b454b4c8ea1512ff1d825510 /extern/gflags/src
parent60712d12eb89fe85204f9a0dbc86e361b8ad6c58 (diff)
Glog/gflags: Reduce amount of local modifications
With better directory layout and more proper include statements we can avoid several local modifications, such as changing config.h for Windows Glog and the ones related on pass-through statements in logging headers in Glog. This commit also makes unused functions not-a-warning for external code.
Diffstat (limited to 'extern/gflags/src')
-rw-r--r--extern/gflags/src/gflags.cc6
-rw-r--r--extern/gflags/src/gflags_completions.cc2
2 files changed, 3 insertions, 5 deletions
diff --git a/extern/gflags/src/gflags.cc b/extern/gflags/src/gflags.cc
index 60965d3d201..f27079862f0 100644
--- a/extern/gflags/src/gflags.cc
+++ b/extern/gflags/src/gflags.cc
@@ -225,7 +225,7 @@ class FlagValue {
bool Equal(const FlagValue& x) const;
FlagValue* New() const; // creates a new one with default value
void CopyFrom(const FlagValue& x);
- inline int ValueSize() const;
+ int ValueSize() const;
// Calls the given validate-fn on value_buffer_, and returns
// whatever it returns. But first casts validate_fn_proto to a
@@ -485,7 +485,7 @@ void FlagValue::CopyFrom(const FlagValue& x) {
}
}
-inline int FlagValue::ValueSize() const {
+int FlagValue::ValueSize() const {
if (type_ > FV_MAX_INDEX) {
assert(false); // unknown type
return 0;
@@ -1257,7 +1257,7 @@ void CommandLineFlagParser::ValidateFlags(bool all) {
}
}
-inline void CommandLineFlagParser::ValidateAllFlags() {
+void CommandLineFlagParser::ValidateAllFlags() {
ValidateFlags(true);
}
diff --git a/extern/gflags/src/gflags_completions.cc b/extern/gflags/src/gflags_completions.cc
index c663453c59c..f7724864d58 100644
--- a/extern/gflags/src/gflags_completions.cc
+++ b/extern/gflags/src/gflags_completions.cc
@@ -55,8 +55,6 @@
#include <utility>
#include <vector>
-#include "gflags_completions.h"
-
#include "config.h"
#include "gflags/gflags.h"
#include "gflags/gflags_completions.h"