diff options
author | Sergey Sharybin <sergey.vfx@gmail.com> | 2018-04-03 18:23:43 +0300 |
---|---|---|
committer | Sergey Sharybin <sergey.vfx@gmail.com> | 2018-04-04 10:48:41 +0300 |
commit | 4674e02562637f36a9900bff5f5f4acc9aff482d (patch) | |
tree | 4fca4fb97dad7c2e34533950d44faeb5ce94e2c0 /source/blender/blenkernel/BKE_armature.h | |
parent | fa01a1738bd1e3a6750ffbe523a282bc22de3991 (diff) |
Depsgraph: Only bind ID-data and indices to depsgraph callbacks
This is a part of copy-on-write sanitization, to avoid all the checks
which were attempting to keep sub-data pointers intact.
Point is: ID pointers never change for CoW datablocks, but nested
data pointers might change when updating existing copy.
Solution: Only bind ID data pointers and index of sub-data.
This will make CoW datablock 7update function was easier in 2.8.
In master we were only using pose channel pointers in callbacks,
this is exactly what this commit addresses. A linear lookup array
is created on pose evaluation init and is thrown away afterwards.
One thing we might consider doing is to keep indexed array of
poses, similar to chanhash.
Reviewers: campbellbarton
Reviewed By: campbellbarton
Subscribers: dfelinto
Differential Revision: https://developer.blender.org/D3124
Diffstat (limited to 'source/blender/blenkernel/BKE_armature.h')
-rw-r--r-- | source/blender/blenkernel/BKE_armature.h | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/source/blender/blenkernel/BKE_armature.h b/source/blender/blenkernel/BKE_armature.h index 60fb79d75d5..f6de39c897e 100644 --- a/source/blender/blenkernel/BKE_armature.h +++ b/source/blender/blenkernel/BKE_armature.h @@ -169,41 +169,39 @@ void BKE_splineik_execute_tree(struct Scene *scene, struct Object *ob, struct bP void BKE_pose_eval_init(struct EvaluationContext *eval_ctx, struct Scene *scene, - struct Object *ob, - struct bPose *pose); + struct Object *ob); void BKE_pose_eval_init_ik(struct EvaluationContext *eval_ctx, struct Scene *scene, - struct Object *ob, - struct bPose *pose); + struct Object *ob); void BKE_pose_eval_bone(struct EvaluationContext *eval_ctx, struct Scene *scene, struct Object *ob, - struct bPoseChannel *pchan); + int pchan_index); void BKE_pose_constraints_evaluate(struct EvaluationContext *eval_ctx, struct Scene *scene, struct Object *ob, - struct bPoseChannel *pchan); + int pchan_index); void BKE_pose_bone_done(struct EvaluationContext *eval_ctx, - struct bPoseChannel *pchan); + struct Object *ob, + int pchan_index); void BKE_pose_iktree_evaluate(struct EvaluationContext *eval_ctx, struct Scene *scene, struct Object *ob, - struct bPoseChannel *rootchan); + int rootchan_index); void BKE_pose_splineik_evaluate(struct EvaluationContext *eval_ctx, struct Scene *scene, struct Object *ob, - struct bPoseChannel *rootchan); + int rootchan_index); void BKE_pose_eval_flush(struct EvaluationContext *eval_ctx, struct Scene *scene, - struct Object *ob, - struct bPose *pose); + struct Object *ob); void BKE_pose_eval_proxy_copy(struct EvaluationContext *eval_ctx, struct Object *ob); |