diff options
| author | Jacques Lucke <jacques@blender.org> | 2021-10-29 10:28:31 +0300 |
|---|---|---|
| committer | Jacques Lucke <jacques@blender.org> | 2021-10-29 10:28:31 +0300 |
| commit | cf771807b7997949611dbf76b43150592c9977cb (patch) | |
| tree | d1b986d9cd4bf56c93edf9755d6163cc6263b0dc /source/blender/blenkernel/BKE_attribute_access.hh | |
| parent | b546202a9afa5ee358893d82e6a1ba0f69cca254 (diff) | |
Geometry Nodes: do cache invalidation after writing attributes
This is a better and more general fix for T92511 and T92508 than
the ones that I committed before.
Previously, we tagged caches dirty when first accessing attributes.
This led to incorrect caches when under some circumstances. Now
cache invalidation is part of `OutputAttribute.save()`.
A nice side benefit of this change is that it may make things more
efficient in some cases, because we don't invalidate caches when
they don't have to be invalidated.
Differential Revision: https://developer.blender.org/D13009
Diffstat (limited to 'source/blender/blenkernel/BKE_attribute_access.hh')
| -rw-r--r-- | source/blender/blenkernel/BKE_attribute_access.hh | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/source/blender/blenkernel/BKE_attribute_access.hh b/source/blender/blenkernel/BKE_attribute_access.hh index 38f5497ed92..cf19eb29a0e 100644 --- a/source/blender/blenkernel/BKE_attribute_access.hh +++ b/source/blender/blenkernel/BKE_attribute_access.hh @@ -183,6 +183,8 @@ struct WriteAttributeLookup { GVMutableArrayPtr varray; /* Domain the attributes lives on in the geometry. */ AttributeDomain domain; + /* Call this after changing the attribute to invalidate caches that depend on this attribute. */ + std::function<void()> tag_modified_fn; /* Convenience function to check if the attribute has been found. */ operator bool() const |