Cleanup: remove redundant const qualifiers for POD types

MSVC used to warn about const mismatch for arguments passed by value.
Remove these as newer versions of MSVC no longer show this warning.

4 files changed, 18 insertions, 19 deletions

diff --git a/source/blender/blenloader/BLO_readfile.h b/source/blender/blenloader/BLO_readfile.h
index 567886e4d54..c4c3b42cb63 100644
--- a/source/blender/blenloader/BLO_readfile.h
+++ b/source/blender/blenloader/BLO_readfile.h
@@ -233,7 +233,7 @@ BlendHandle *BLO_blendhandle_from_memory(const void *mem,
 struct LinkNode *BLO_blendhandle_get_datablock_names(BlendHandle *bh,
                                                      int ofblocktype,
 
-                                                     const bool use_assets_only,
+                                                     bool use_assets_only,
                                                      int *r_tot_names);
 /**
  * Gets the names and asset-data (if ID is an asset) of data-blocks in a file of a certain type.
@@ -246,8 +246,10 @@ struct LinkNode *BLO_blendhandle_get_datablock_names(BlendHandle *bh,
  * \return A BLI_linklist of `BLODataBlockInfo *`.
  * The links and #BLODataBlockInfo.asset_data should be freed with MEM_freeN.
  */
-struct LinkNode * /*BLODataBlockInfo */ BLO_blendhandle_get_datablock_info(
-    BlendHandle *bh, int ofblocktype, const bool use_assets_only, int *r_tot_info_items);
+struct LinkNode * /*BLODataBlockInfo */ BLO_blendhandle_get_datablock_info(BlendHandle *bh,
+                                                                           int ofblocktype,
+                                                                           bool use_assets_only,
+                                                                           int *r_tot_info_items);
 /**
  * Gets the previews of all the data-blocks in a file of a certain type
  * (e.g. all the scene previews in a file).
@@ -367,12 +369,12 @@ typedef struct LibraryLink_Params {
 
 void BLO_library_link_params_init(struct LibraryLink_Params *params,
                                   struct Main *bmain,
-                                  const int flag,
-                                  const int id_tag_extra);
+                                  int flag,
+                                  int id_tag_extra);
 void BLO_library_link_params_init_with_context(struct LibraryLink_Params *params,
                                                struct Main *bmain,
-                                               const int flag,
-                                               const int id_tag_extra,
+                                               int flag,
+                                               int id_tag_extra,
                                                struct Scene *scene,
                                                struct ViewLayer *view_layer,
                                                const struct View3D *v3d);
@@ -400,7 +402,7 @@ struct Main *BLO_library_link_begin(BlendHandle **bh,
  */
 struct ID *BLO_library_link_named_part(struct Main *mainl,
                                        BlendHandle **bh,
-                                       const short idcode,
+                                       short idcode,
                                        const char *name,
                                        const struct LibraryLink_Params *params);
 /**
@@ -435,7 +437,7 @@ typedef struct TempLibraryContext {
 
 TempLibraryContext *BLO_library_temp_load_id(struct Main *real_main,
                                              const char *blend_file_path,
-                                             const short idcode,
+                                             short idcode,
                                              const char *idname,
                                              struct ReportList *reports);
 void BLO_library_temp_free(TempLibraryContext *temp_lib_ctx);
diff --git a/source/blender/blenloader/BLO_writefile.h b/source/blender/blenloader/BLO_writefile.h
index 9bc3714ff38..072f86b48d6 100644
--- a/source/blender/blenloader/BLO_writefile.h
+++ b/source/blender/blenloader/BLO_writefile.h
@@ -69,7 +69,7 @@ struct BlendFileWriteParams {
  */
 extern bool BLO_write_file(struct Main *mainvar,
                            const char *filepath,
-                           const int write_flags,
+                           int write_flags,
                            const struct BlendFileWriteParams *params,
                            struct ReportList *reports);
 
diff --git a/source/blender/blenloader/intern/readfile.h b/source/blender/blenloader/intern/readfile.h
index 3b5be3dd013..21b0354b097 100644
--- a/source/blender/blenloader/intern/readfile.h
+++ b/source/blender/blenloader/intern/readfile.h
@@ -200,7 +200,7 @@ struct AssetMetaData *blo_bhead_id_asset_data_address(const FileData *fd, const
  *
  * \attention ONLY USE THIS KIND OF VERSIONING WHEN `dna_rename_defs.h` ISN'T SUFFICIENT.
  */
-void blo_do_versions_dna(struct SDNA *sdna, const int versionfile, const int subversionfile);
+void blo_do_versions_dna(struct SDNA *sdna, int versionfile, int subversionfile);
 
 void blo_do_versions_oldnewmap_insert(struct OldNewMap *onm,
                                       const void *oldaddr,
diff --git a/source/blender/blenloader/intern/versioning_common.h b/source/blender/blenloader/intern/versioning_common.h
index 9e13cc45103..ea850a052ae 100644
--- a/source/blender/blenloader/intern/versioning_common.h
+++ b/source/blender/blenloader/intern/versioning_common.h
@@ -39,21 +39,18 @@ struct ARegion *do_versions_add_region_if_not_found(struct ListBase *regionbase,
  *
  * \return the ID (if found).
  */
-ID *do_versions_rename_id(Main *bmain,
-                          const short id_type,
-                          const char *name_src,
-                          const char *name_dst);
+ID *do_versions_rename_id(Main *bmain, short id_type, const char *name_src, const char *name_dst);
 
 void version_node_socket_name(struct bNodeTree *ntree,
-                              const int node_type,
+                              int node_type,
                               const char *old_name,
                               const char *new_name);
 void version_node_input_socket_name(struct bNodeTree *ntree,
-                                    const int node_type,
+                                    int node_type,
                                     const char *old_name,
                                     const char *new_name);
 void version_node_output_socket_name(struct bNodeTree *ntree,
-                                     const int node_type,
+                                     int node_type,
                                      const char *old_name,
                                      const char *new_name);
 
@@ -85,7 +82,7 @@ void version_node_socket_index_animdata(
 /**
  * Replace the ID name of all nodes in the tree with the given type with the new name.
  */
-void version_node_id(struct bNodeTree *ntree, const int node_type, const char *new_name);
+void version_node_id(struct bNodeTree *ntree, int node_type, const char *new_name);
 
 /**
  * Convert `SocketName.001` unique name format to `SocketName_001`. Previously both were used.