Fix sculpt mode drawing with modifiers still being wrong in some cases

Centralize logic for when to use the PBVH for drawing, fix missing tests in
mask drawing, fix missing tests for multiple windows, only do more expensive
update for all viewports at end of the stroke.

1 files changed, 0 insertions, 22 deletions

diff --git a/source/blender/draw/intern/draw_manager.c b/source/blender/draw/intern/draw_manager.c
index 6428eb77ddb..9e69cfa7ea4 100644
--- a/source/blender/draw/intern/draw_manager.c
+++ b/source/blender/draw/intern/draw_manager.c
@@ -217,28 +217,6 @@ bool DRW_object_use_hide_faces(const struct Object *ob)
   return false;
 }
 
-/* Should we use PBVH drawing or regular mesh drawing
- * PBVH drawing should be used for
- *  - Multires
- *  - Dyntopo
- *  - Normal sculpt without any active modifiers
- */
-bool DRW_object_use_pbvh_drawing(const struct Object *ob)
-{
-  SculptSession *ss = ob->sculpt;
-  if (ss == NULL || ss->pbvh == NULL || ob->sculpt->mode_type != OB_MODE_SCULPT) {
-    return false;
-  }
-
-  if (BKE_pbvh_type(ss->pbvh) == PBVH_FACES) {
-    return !(ss->kb || ss->modifiers_active);
-  }
-  else {
-    /* Multires/Dyntopo */
-    return true;
-  }
-}
-
 bool DRW_object_is_visible_psys_in_active_context(const Object *object, const ParticleSystem *psys)
 {
   const bool for_render = DRW_state_is_image_render();