diff options
author | Jacques Lucke <jacques@blender.org> | 2022-03-14 12:49:03 +0300 |
---|---|---|
committer | Philipp Oeser <info@graphics-engineer.com> | 2022-03-21 15:18:05 +0300 |
commit | 45482ac5764f133f401dd84cc1df1c9e331ca239 (patch) | |
tree | 5f9b0b2330a3ee38cc5ac2d076677158817c68f8 /source | |
parent | b125046c754aa23ca5abb73c7eea10c916d2edcb (diff) |
Fix T96402: fix case when material output is contained in node group
For now just assume that a node group without output sockets is
an output node. Ideally, we would use run-time information stored
on the node group itself to determine if the group contains a
top-level output node (e.g. Material Output). That can be
implemented separately.
In the larger scheme of things, top-level outputs within node
groups seem to break the node group abstraction and reusability
a bit.
Diffstat (limited to 'source')
-rw-r--r-- | source/blender/blenkernel/intern/node_tree_update.cc | 21 |
1 files changed, 19 insertions, 2 deletions
diff --git a/source/blender/blenkernel/intern/node_tree_update.cc b/source/blender/blenkernel/intern/node_tree_update.cc index 711aee57b5a..d30fa00e56f 100644 --- a/source/blender/blenkernel/intern/node_tree_update.cc +++ b/source/blender/blenkernel/intern/node_tree_update.cc @@ -1353,8 +1353,7 @@ class NodeTreeMainUpdater { { Vector<const SocketRef *> sockets; for (const NodeRef *node : tree.nodes()) { - const bNode *bnode = node->bnode(); - if (bnode->typeinfo->nclass != NODE_CLASS_OUTPUT && bnode->type != NODE_GROUP_OUTPUT) { + if (!this->is_output_node(*node)) { continue; } for (const InputSocketRef *socket : node->inputs()) { @@ -1366,6 +1365,24 @@ class NodeTreeMainUpdater { return sockets; } + bool is_output_node(const NodeRef &node) const + { + const bNode &bnode = *node.bnode(); + if (bnode.typeinfo->nclass == NODE_CLASS_OUTPUT) { + return true; + } + if (bnode.type == NODE_GROUP_OUTPUT) { + return true; + } + /* Assume node groups without output sockets are outputs. */ + /* TODO: Store whether a node group contains a top-level output node (e.g. Material Output) in + * run-time information on the node group itself. */ + if (bnode.type == NODE_GROUP && node.outputs().is_empty()) { + return true; + } + return false; + } + /** * Computes a hash that changes when the node tree topology connected to an output node changes. * Adding reroutes does not have an effect on the hash. |