Default IMapper interface methods

35 files changed, 23 insertions, 279 deletions

diff --git a/FamicomDumper/IMapper.cs b/FamicomDumper/IMapper.cs
index 3f8c221..738cf12 100644
--- a/FamicomDumper/IMapper.cs
+++ b/FamicomDumper/IMapper.cs
@@ -1,7 +1,10 @@
 using com.clusterrr.Famicom.Containers;

 using com.clusterrr.Famicom.DumperConnection;

+using System;

 using System.Collections.Generic;

 

+#nullable disable

+

 namespace com.clusterrr.Famicom.Dumper

 {

     public interface IMapper

@@ -14,17 +17,17 @@ namespace com.clusterrr.Famicom.Dumper
         /// <summary>

         /// Number of the mapper to spore in the iNES header (-1 if none)

         /// </summary>

-        int Number { get; }

+        int Number { get => -1; }

 

         /// <summary>

         /// Number of submapper (0 if none)

         /// </summary>

-        byte Submapper { get; }

+        byte Submapper { get => 0; }

 

         /// <summary>

         /// Name of the mapper to store in UNIF container (null if none)

         /// </summary>

-        string UnifName { get; }

+        string UnifName { get => null; }

 

         /// <summary>

         /// Default PRG size to dump (in bytes)

@@ -34,7 +37,7 @@ namespace com.clusterrr.Famicom.Dumper
         /// <summary>

         /// Default CHR size to dump (in bytes)

         /// </summary>

-        int DefaultChrSize { get; }

+        int DefaultChrSize { get => 0; }

 

         /// <summary>

         /// This method will be called to dump PRG

@@ -50,42 +53,44 @@ namespace com.clusterrr.Famicom.Dumper
         /// <param name="dumper">FamicomDumperConnection object to access cartridge</param>

         /// <param name="data">This list must be filled with dumped CHR data</param>

         /// <param name="size">Size of CHR to dump requested by user (in bytes)</param>

-        void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size = 0);

+        void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size = 0)

+            => throw new NotSupportedException("This mapper doesn't have a CHR ROM");

 

         /// <summary>

         /// This method will be called to enable PRG RAM

         /// </summary>

         /// <param name="dumper"></param>

-        void EnablePrgRam(IFamicomDumperConnection dumper);

+        void EnablePrgRam(IFamicomDumperConnection dumper) 

+            => throw new NotImplementedException("PRG RAM is not supported by this mapper");

 

         /// <summary>

         /// This method must return mirroring type, it can call dumper.GetMirroring() if it's fixed

         /// </summary>

         /// <param name="dumper">FamicomDumperConnection object to access cartridge</param>

         /// <returns>Mirroring type</returns>

-        MirroringType GetMirroring(IFamicomDumperConnection dumper);

+        MirroringType GetMirroring(IFamicomDumperConnection dumper) => dumper.GetMirroring();

 

         /* Optional properties */

-        /*

         /// <summary>

         /// Default PRG RAM size, can be used with NES 2.0

         /// </summary>

-        int DefaultPrgRamSize { get; }

+        public int DefaultPrgRamSize { get => -1; }

 

         /// <summary>

         /// Default CHR RAM size, can be used with NES 2.0

         /// </summary>

-        int DefaultChrRamSize { get; }

+        public int DefaultChrRamSize { get => -1; }

 

         /// <summary>

         /// Default PRG NVRAM size, can be used with NES 2.0

         /// </summary>

-        int DefaultPrgNvramSize { get; }

+        public int DefaultPrgNvramSize { get => -1; }

 

         /// <summary>

         /// Default CHR NVRAM size, can be used with NES 2.0

         /// </summary>

-        int DefaultChrNvramSize { get; }

-        */

+        public int DefaultChrNvramSize { get => -1; }

     }

 }

+

+#nullable restore

diff --git a/FamicomDumper/Program.cs b/FamicomDumper/Program.cs
index 0352688..c46157e 100644
--- a/FamicomDumper/Program.cs
+++ b/FamicomDumper/Program.cs
@@ -550,40 +550,13 @@ namespace com.clusterrr.Famicom.Dumper
 

             // Get optional properties

             // int DefaultPrgRamSize -> PRG RAM size

-            if (prgRamSize < 0) {

-                var method = mapper.GetType().GetProperty(

-                        "DefaultPrgRamSize", BindingFlags.Instance | BindingFlags.Public,

-                        null, typeof(int), Array.Empty<Type>(),

-                        Array.Empty<ParameterModifier>());

-                if (method != null) prgRamSize = (int)method.GetValue(mapper)!;

-            }

+            if (prgRamSize < 0) prgRamSize = mapper.DefaultPrgRamSize;

             // int DefaultChrRamSize -> CHR RAM size

-            if (chrRamSize < 0)

-            {

-                var method = mapper.GetType().GetProperty(

-                        "DefaultChrRamSize", BindingFlags.Instance | BindingFlags.Public,

-                        null, typeof(int), Array.Empty<Type>(),

-                        Array.Empty<ParameterModifier>());

-                if (method != null) chrRamSize = (int)method.GetValue(mapper)!;

-            }

+            if (chrRamSize < 0) chrRamSize = mapper.DefaultChrRamSize;

             // int DefaultPrgNvramSize -> PRG NVRAM size

-            if (prgNvRamSize < 0)

-            {

-                var method = mapper.GetType().GetProperty(

-                        "DefaultPrgNvramSize", BindingFlags.Instance | BindingFlags.Public,

-                        null, typeof(int), Array.Empty<Type>(),

-                        Array.Empty<ParameterModifier>());

-                if (method != null) prgNvRamSize = (int)method.GetValue(mapper)!;

-            }

+            if (prgNvRamSize < 0) prgNvRamSize = mapper.DefaultPrgNvramSize;

             // int DefaultChrNvramSize -> CHR NVRAM size

-            if (chrNvRamSize < 0)

-            {

-                var method = mapper.GetType().GetProperty(

-                        "DefaultChrNvramSize", BindingFlags.Instance | BindingFlags.Public,

-                        null, typeof(int), Array.Empty<Type>(),

-                        Array.Empty<ParameterModifier>());

-                if (method != null) chrNvRamSize = (int)method.GetValue(mapper)!;

-            }

+            if (chrNvRamSize < 0) chrNvRamSize = mapper.DefaultChrNvramSize;

 

             Console.WriteLine("Dumping...");

             var prg = new List<byte>();

@@ -626,7 +599,7 @@ namespace com.clusterrr.Famicom.Dumper
                     nesFile.PrgNvRamSize = (uint)Math.Max(0, prgNvRamSize);

                     nesFile.ChrRamSize = (uint)Math.Max(0, chrRamSize);

                     nesFile.ChrNvRamSize = (uint)Math.Max(0, chrNvRamSize);

-                    nesFile.Battery = battery;

+                    nesFile.Battery = battery || nesFile.PrgNvRamSize > 0 || nesFile.ChrNvRamSize > 0;

                     nesFile.Save(fileName);

                     break;

                 case ".unf":

diff --git a/FamicomDumper/mappers/114.cs b/FamicomDumper/mappers/114.cs
index 4aefe57..ef58e6b 100644
--- a/FamicomDumper/mappers/114.cs
+++ b/FamicomDumper/mappers/114.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "MMC3 SG PROT. A"; }

     public int Number { get => 114; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 512 * 1024; }

     public int DefaultChrSize { get => 256 * 1024; }

 

@@ -69,11 +67,6 @@
         }

     }

 

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

     public MirroringType GetMirroring(IFamicomDumperConnection dumper)

     {

         return MirroringType.MapperControlled;

diff --git a/FamicomDumper/mappers/19.cs b/FamicomDumper/mappers/19.cs
index d6f752c..4946406 100644
--- a/FamicomDumper/mappers/19.cs
+++ b/FamicomDumper/mappers/19.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "Namco 129/163"; }

     public int Number { get => 19; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 512 * 1024; }

     public int DefaultChrSize { get => 256 * 1024; }

 

diff --git a/FamicomDumper/mappers/202.cs b/FamicomDumper/mappers/202.cs
index ee59fc6..919e678 100644
--- a/FamicomDumper/mappers/202.cs
+++ b/FamicomDumper/mappers/202.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "Mapper 202"; }

     public int Number { get => 202; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 8 * 0x4000; }

     public int DefaultChrSize { get => 8 * 0x2000; }

 

@@ -31,11 +29,6 @@
         }

     }

 

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

     public MirroringType GetMirroring(IFamicomDumperConnection dumper)

     {

         return MirroringType.MapperControlled;

diff --git a/FamicomDumper/mappers/203.cs b/FamicomDumper/mappers/203.cs
index 9322fbc..74191d9 100644
--- a/FamicomDumper/mappers/203.cs
+++ b/FamicomDumper/mappers/203.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "Mapper 203"; }

     public int Number { get => 203; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 4 * 0x4000; }

     public int DefaultChrSize { get => 4 * 0x2000; }

 

@@ -30,14 +28,4 @@
             Console.WriteLine("OK");

         }

     }

-

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

-    public MirroringType GetMirroring(IFamicomDumperConnection dumper)

-    {

-        return dumper.GetMirroring();

-    }

 }

diff --git a/FamicomDumper/mappers/210.cs b/FamicomDumper/mappers/210.cs
index e237e7d..27fa7f7 100644
--- a/FamicomDumper/mappers/210.cs
+++ b/FamicomDumper/mappers/210.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "Mapper 210"; }

     public int Number { get => 210; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 512 * 1024; }

     public int DefaultChrSize { get => 256 * 1024; }

 

@@ -32,14 +30,4 @@
             Console.WriteLine("OK");

         }

     }

-

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        dumper.WriteCpu(0xC000, 0x01);

-    }

-

-    public MirroringType GetMirroring(IFamicomDumperConnection dumper)

-    {

-        return dumper.GetMirroring();

-    }

 }

diff --git a/FamicomDumper/mappers/57.cs b/FamicomDumper/mappers/57.cs
index b6de20e..b694a76 100644
--- a/FamicomDumper/mappers/57.cs
+++ b/FamicomDumper/mappers/57.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "Mapper 57"; }

     public int Number { get => 57; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 8 * 0x4000; }

     public int DefaultChrSize { get => 8 * 0x2000; }

 

diff --git a/FamicomDumper/mappers/58.cs b/FamicomDumper/mappers/58.cs
index 7301d1a..0d7f901 100644
--- a/FamicomDumper/mappers/58.cs
+++ b/FamicomDumper/mappers/58.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "Mapper 58"; }

     public int Number { get => 58; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 8 * 0x4000; }

     public int DefaultChrSize { get => 8 * 0x2000; }

 

@@ -31,11 +29,6 @@
         }

     }

 

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

     public MirroringType GetMirroring(IFamicomDumperConnection dumper)

     {

         return MirroringType.MapperControlled;

diff --git a/FamicomDumper/mappers/87.cs b/FamicomDumper/mappers/87.cs
index 7cb818e..63822a5 100644
--- a/FamicomDumper/mappers/87.cs
+++ b/FamicomDumper/mappers/87.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "Mapper 87"; }

     public int Number { get => 87; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 0x8000; }

     public int DefaultChrSize { get => 0x2000 * 4; }

 

@@ -27,11 +25,6 @@
         }

     }

 

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

     public MirroringType GetMirroring(IFamicomDumperConnection dumper)

     {

         return dumper.GetMirroring();

diff --git a/FamicomDumper/mappers/AA6023Sub0.cs b/FamicomDumper/mappers/AA6023Sub0.cs
index 965fb2d..5d9ffff 100644
--- a/FamicomDumper/mappers/AA6023Sub0.cs
+++ b/FamicomDumper/mappers/AA6023Sub0.cs
@@ -5,7 +5,6 @@
     public byte Submapper { get => 0; }
     public string UnifName { get => "COOLBOY"; }
     public int DefaultPrgSize { get => 32 * 1024 * 1024; }
-    public int DefaultChrSize { get => 0; }
     public int DefaultPrgRamSize { get => 8 * 1024; }
     public int DefaultChrRamSize { get => 256 * 1024; }
 
@@ -39,11 +38,6 @@
         }
     }
 
-    public void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size)
-    {
-        throw new NotSupportedException("This mapper doesn't have a CHR ROM");
-    }
-
     public void EnablePrgRam(IFamicomDumperConnection dumper)
     {
         dumper.Reset();
diff --git a/FamicomDumper/mappers/AA6023Sub1.cs b/FamicomDumper/mappers/AA6023Sub1.cs
index 648ff89..ce2a016 100644
--- a/FamicomDumper/mappers/AA6023Sub1.cs
+++ b/FamicomDumper/mappers/AA6023Sub1.cs
@@ -5,7 +5,6 @@
     public byte Submapper { get => 1; }
     public string UnifName { get => "MINDKIDS"; }
     public int DefaultPrgSize { get => 32 * 1024 * 1024; }
-    public int DefaultChrSize { get => 0; }
     public int DefaultPrgRamSize { get => 8 * 1024; }
     public int DefaultChrRamSize { get => 256 * 1024; }
 
@@ -39,11 +38,6 @@
         }
     }
 
-    public void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size)
-    {
-        throw new NotSupportedException("This mapper doesn't have a CHR ROM");
-    }
-
     public void EnablePrgRam(IFamicomDumperConnection dumper)
     {
         dumper.Reset();
diff --git a/FamicomDumper/mappers/AA6023Sub2.cs b/FamicomDumper/mappers/AA6023Sub2.cs
index 6e0d6e4..6214c8b 100644
--- a/FamicomDumper/mappers/AA6023Sub2.cs
+++ b/FamicomDumper/mappers/AA6023Sub2.cs
@@ -5,7 +5,6 @@
     public byte Submapper { get => 2; }
     public string UnifName { get => null; }
     public int DefaultPrgSize { get => 32 * 1024 * 1024; }
-    public int DefaultChrSize { get => 0; }
     public int DefaultPrgRamSize { get => 8 * 1024; }
     public int DefaultChrRamSize { get => 256 * 1024; }
 
@@ -41,11 +40,6 @@
         }
     }
 
-    public void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size)
-    {
-        throw new NotSupportedException("This mapper doesn't have a CHR ROM");
-    }
-
     public void EnablePrgRam(IFamicomDumperConnection dumper)
     {
         dumper.Reset();
diff --git a/FamicomDumper/mappers/AA6023Sub3.cs b/FamicomDumper/mappers/AA6023Sub3.cs
index fd19bf7..6ee81b6 100644
--- a/FamicomDumper/mappers/AA6023Sub3.cs
+++ b/FamicomDumper/mappers/AA6023Sub3.cs
@@ -5,7 +5,6 @@
     public byte Submapper { get => 3; }
     public string UnifName { get => null; }
     public int DefaultPrgSize { get => 32 * 1024 * 1024; }
-    public int DefaultChrSize { get => 0; }
     public int DefaultPrgRamSize { get => 8 * 1024; }
     public int DefaultChrRamSize { get => 256 * 1024; }
 
@@ -41,11 +40,6 @@
         }
     }
 
-    public void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size)
-    {
-        throw new NotSupportedException("This mapper doesn't have a CHR ROM");
-    }
-
     public void EnablePrgRam(IFamicomDumperConnection dumper)
     {
         dumper.Reset();
diff --git a/FamicomDumper/mappers/AxROM.cs b/FamicomDumper/mappers/AxROM.cs
index 6c27665..85c46f1 100644
--- a/FamicomDumper/mappers/AxROM.cs
+++ b/FamicomDumper/mappers/AxROM.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "AxROM"; }

     public int Number { get => 7; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 256 * 1024; }

     public int DefaultChrSize { get => 0; }

 

@@ -36,16 +34,6 @@
         }

     }

 

-    public void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size)

-    {

-        throw new NotSupportedException("This mapper doesn't have a CHR ROM");

-    }

-

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

     public MirroringType GetMirroring(IFamicomDumperConnection dumper)

     {

         return MirroringType.MapperControlled;

diff --git a/FamicomDumper/mappers/CNROM.cs b/FamicomDumper/mappers/CNROM.cs
index 07ce911..33c00b6 100644
--- a/FamicomDumper/mappers/CNROM.cs
+++ b/FamicomDumper/mappers/CNROM.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "CNROM"; }

     public int Number { get => 3; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 0x8000; }

     public int DefaultChrSize { get => 0x2000 * 4; }

 

@@ -41,14 +39,4 @@
             Console.WriteLine("OK");

         }

     }

-

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

-    public MirroringType GetMirroring(IFamicomDumperConnection dumper)

-    {

-        return dumper.GetMirroring();

-    }

 }

diff --git a/FamicomDumper/mappers/ColorDreams.cs b/FamicomDumper/mappers/ColorDreams.cs
index c81400d..25f3fd5 100644
--- a/FamicomDumper/mappers/ColorDreams.cs
+++ b/FamicomDumper/mappers/ColorDreams.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "ColorDreams"; }

     public int Number { get => 11; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 0x8000 * 4; }

     public int DefaultChrSize { get => 0x2000 * 16; }

 

@@ -64,14 +62,4 @@
             Console.WriteLine("OK");

         }

     }

-

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

-    public MirroringType GetMirroring(IFamicomDumperConnection dumper)

-    {

-        return dumper.GetMirroring();

-    }

 }

diff --git a/FamicomDumper/mappers/Coolgirl.cs b/FamicomDumper/mappers/Coolgirl.cs
index 894034c..8514cda 100644
--- a/FamicomDumper/mappers/Coolgirl.cs
+++ b/FamicomDumper/mappers/Coolgirl.cs
@@ -2,10 +2,8 @@
 {

     public string Name { get => "COOLGIRL"; }

     public int Number { get => 342; }

-    public byte Submapper { get => 0; }

     public string UnifName { get => "COOLGIRL"; }

     public int DefaultPrgSize { get => 1024 * 1024 * 128; }

-    public int DefaultChrSize { get => 0; }

     public int DefaultPrgRamSize { get => 32 * 1024; }

     public int DefaultChrRamSize { get => 512 * 1024; }

 

@@ -29,11 +27,6 @@
         }

     }

 

-    public void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size)

-    {

-        throw new NotSupportedException("This mapper doesn't have a CHR ROM");

-    }

-

     public void EnablePrgRam(IFamicomDumperConnection dumper)

     {

         dumper.Reset();

diff --git a/FamicomDumper/mappers/MMC1.cs b/FamicomDumper/mappers/MMC1.cs
index 96e38df..adb4471 100644
--- a/FamicomDumper/mappers/MMC1.cs
+++ b/FamicomDumper/mappers/MMC1.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "MMC1"; }

     public int Number { get => 1; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 256 * 1024; }

     public int DefaultChrSize { get => 128 * 1024; }

 

diff --git a/FamicomDumper/mappers/MMC2.cs b/FamicomDumper/mappers/MMC2.cs
index ca42c94..1a3ebd0 100644
--- a/FamicomDumper/mappers/MMC2.cs
+++ b/FamicomDumper/mappers/MMC2.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "MMC2"; }

     public int Number { get => 9; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 128 * 1024; }

     public int DefaultChrSize { get => 0; }

 

@@ -34,11 +32,6 @@
         }

     }

 

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

     public MirroringType GetMirroring(IFamicomDumperConnection dumper)

     {

         return MirroringType.MapperControlled;

diff --git a/FamicomDumper/mappers/MMC3.cs b/FamicomDumper/mappers/MMC3.cs
index a59e6b9..71ae64f 100644
--- a/FamicomDumper/mappers/MMC3.cs
+++ b/FamicomDumper/mappers/MMC3.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "MMC3"; }

     public int Number { get => 4; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 512 * 1024; }

     public int DefaultChrSize { get => 256 * 1024; }

 

diff --git a/FamicomDumper/mappers/MMC4.cs b/FamicomDumper/mappers/MMC4.cs
index 0eb9a9a..510e7f9 100644
--- a/FamicomDumper/mappers/MMC4.cs
+++ b/FamicomDumper/mappers/MMC4.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "MMC4"; }

     public int Number { get => 10; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 256 * 1024; }

     public int DefaultChrSize { get => 0; }

 

@@ -34,11 +32,6 @@
         }

     }

 

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

     public MirroringType GetMirroring(IFamicomDumperConnection dumper)

     {

         return MirroringType.MapperControlled;

diff --git a/FamicomDumper/mappers/MMC5.cs b/FamicomDumper/mappers/MMC5.cs
index b76a284..1b7ddb8 100644
--- a/FamicomDumper/mappers/MMC5.cs
+++ b/FamicomDumper/mappers/MMC5.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "MMC5"; }

     public int Number { get => 5; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 1024 * 1024; }

     public int DefaultChrSize { get => 1024 * 1024; }

 

diff --git a/FamicomDumper/mappers/NROM.cs b/FamicomDumper/mappers/NROM.cs
index ac7ab01..a28421f 100644
--- a/FamicomDumper/mappers/NROM.cs
+++ b/FamicomDumper/mappers/NROM.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "NROM"; }

     public int Number { get => 0; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 0x8000; }

     public int DefaultChrSize { get => 0x2000; }

 

@@ -25,9 +23,4 @@
     {

         // Actually PRG RAM is present in Family Basic

     }

-

-    public MirroringType GetMirroring(IFamicomDumperConnection dumper)

-    {

-        return dumper.GetMirroring();

-    }

 }

diff --git a/FamicomDumper/mappers/Sunsoft5A-5B-FME7.cs b/FamicomDumper/mappers/Sunsoft5A-5B-FME7.cs
index c3dd1b2..763a94e 100644
--- a/FamicomDumper/mappers/Sunsoft5A-5B-FME7.cs
+++ b/FamicomDumper/mappers/Sunsoft5A-5B-FME7.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "FME-7"; }

     public int Number { get => 69; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 512 * 1024; }

     public int DefaultChrSize { get => 256 * 1024; }

 

diff --git a/FamicomDumper/mappers/UNROM-512.cs b/FamicomDumper/mappers/UNROM-512.cs
index ec3a240..60b73ff 100644
--- a/FamicomDumper/mappers/UNROM-512.cs
+++ b/FamicomDumper/mappers/UNROM-512.cs
@@ -2,10 +2,7 @@
 {
     public string Name { get => "UNROM-512"; }
     public int Number { get => 30; }
-    public byte Submapper { get => 0; }
-    public string UnifName { get => null; }
     public int DefaultPrgSize { get => 512 * 1024; }
-    public int DefaultChrSize { get => 0; }
 
     public void DumpPrg(IFamicomDumperConnection dumper, List<byte> data, int size)
     {
@@ -35,19 +32,4 @@
         }
         data.AddRange(lastBank);
     }
-
-    public void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size)
-    {
-        throw new NotSupportedException("This mapper doesn't have a CHR ROM");
-    }
-
-    public void EnablePrgRam(IFamicomDumperConnection dumper)
-    {
-        throw new NotSupportedException("PRG RAM is not supported by this mapper");
-    }
-
-    public MirroringType GetMirroring(IFamicomDumperConnection dumper)
-    {
-        return dumper.GetMirroring();
-    }
 }
diff --git a/FamicomDumper/mappers/UxROM.cs b/FamicomDumper/mappers/UxROM.cs
index 1a8b1fe..77cce60 100644
--- a/FamicomDumper/mappers/UxROM.cs
+++ b/FamicomDumper/mappers/UxROM.cs
@@ -2,10 +2,7 @@
 {

     public string Name { get => "UxROM"; }

     public int Number { get => 2; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 256 * 1024; }

-    public int DefaultChrSize { get => 0; }

 

     public void DumpPrg(IFamicomDumperConnection dumper, List<byte> data, int size)

     {

@@ -35,19 +32,4 @@
         }

         data.AddRange(lastBank);

     }

-

-    public void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size)

-    {

-        throw new NotSupportedException("This mapper doesn't have a CHR ROM");

-    }

-

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

-    public MirroringType GetMirroring(IFamicomDumperConnection dumper)

-    {

-        return dumper.GetMirroring();

-    }

 }

diff --git a/FamicomDumper/mappers/VRC2a.cs b/FamicomDumper/mappers/VRC2a.cs
index 39f1587..f32ff8a 100644
--- a/FamicomDumper/mappers/VRC2a.cs
+++ b/FamicomDumper/mappers/VRC2a.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "VRC2a"; }

     public int Number { get => 22; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 256 * 1024; }

     public int DefaultChrSize { get => 256 * 1024; }

 

@@ -35,11 +33,6 @@
         }

     }

 

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

     public MirroringType GetMirroring(IFamicomDumperConnection dumper)

     {

         return MirroringType.MapperControlled;

diff --git a/FamicomDumper/mappers/VRC2b4f4e.cs b/FamicomDumper/mappers/VRC2b4f4e.cs
index cb8c14b..319fc8c 100644
--- a/FamicomDumper/mappers/VRC2b4f4e.cs
+++ b/FamicomDumper/mappers/VRC2b4f4e.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "VRC2b/VRC4f/VRC4e"; }

     public int Number { get => 23; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 256 * 1024; }

     public int DefaultChrSize { get => 512 * 1024; }

 

@@ -35,11 +33,6 @@
         }

     }

 

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

     public MirroringType GetMirroring(IFamicomDumperConnection dumper)

     {

         return MirroringType.MapperControlled;

diff --git a/FamicomDumper/mappers/VRC3.cs b/FamicomDumper/mappers/VRC3.cs
index 7532b90..e26e9e5 100644
--- a/FamicomDumper/mappers/VRC3.cs
+++ b/FamicomDumper/mappers/VRC3.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "VRC3"; }

     public int Number { get => 73; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 128 * 1024; }

     public int DefaultChrSize { get => 0; }

 

@@ -20,16 +18,6 @@
         }

     }

 

-    public void DumpChr(IFamicomDumperConnection dumper, List<byte> data, int size)

-    {

-        throw new NotSupportedException("This mapper doesn't have a CHR ROM");

-    }

-

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

     public MirroringType GetMirroring(IFamicomDumperConnection dumper)

     {

         return MirroringType.MapperControlled;

diff --git a/FamicomDumper/mappers/VRC4a4c.cs b/FamicomDumper/mappers/VRC4a4c.cs
index cf12acb..2542670 100644
--- a/FamicomDumper/mappers/VRC4a4c.cs
+++ b/FamicomDumper/mappers/VRC4a4c.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "VRC4a/VRC4c"; }

     public int Number { get => 21; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 256 * 1024; }

     public int DefaultChrSize { get => 512 * 1024; }

 

@@ -35,11 +33,6 @@
         }

     }

 

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

     public MirroringType GetMirroring(IFamicomDumperConnection dumper)

     {

         return MirroringType.MapperControlled;

diff --git a/FamicomDumper/mappers/VRC4b4d.cs b/FamicomDumper/mappers/VRC4b4d.cs
index a8afadf..e84a8a4 100644
--- a/FamicomDumper/mappers/VRC4b4d.cs
+++ b/FamicomDumper/mappers/VRC4b4d.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "VRC4b/VRC4d"; }

     public int Number { get => 25; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 256 * 1024; }

     public int DefaultChrSize { get => 512 * 1024; }

 

@@ -35,11 +33,6 @@
         }

     }

 

-    public void EnablePrgRam(IFamicomDumperConnection dumper)

-    {

-        throw new NotSupportedException("PRG RAM is not supported by this mapper");

-    }

-

     public MirroringType GetMirroring(IFamicomDumperConnection dumper)

     {

         return MirroringType.MapperControlled;

diff --git a/FamicomDumper/mappers/VRC6a.cs b/FamicomDumper/mappers/VRC6a.cs
index 4277d95..b1b7eb3 100644
--- a/FamicomDumper/mappers/VRC6a.cs
+++ b/FamicomDumper/mappers/VRC6a.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "VRC6a"; }

     public int Number { get => 24; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 256 * 1024; }

     public int DefaultChrSize { get => 256 * 1024; }

 

diff --git a/FamicomDumper/mappers/VRC6b.cs b/FamicomDumper/mappers/VRC6b.cs
index eaf866b..f9870b5 100644
--- a/FamicomDumper/mappers/VRC6b.cs
+++ b/FamicomDumper/mappers/VRC6b.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "VRC6b"; }

     public int Number { get => 26; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 256 * 1024; }

     public int DefaultChrSize { get => 256 * 1024; }

 

diff --git a/FamicomDumper/mappers/VRC7.cs b/FamicomDumper/mappers/VRC7.cs
index 3847090..a0075e3 100644
--- a/FamicomDumper/mappers/VRC7.cs
+++ b/FamicomDumper/mappers/VRC7.cs
@@ -2,8 +2,6 @@
 {

     public string Name { get => "VRC7"; }

     public int Number { get => 85; }

-    public byte Submapper { get => 0; }

-    public string UnifName { get => null; }

     public int DefaultPrgSize { get => 512 * 1024; }

     public int DefaultChrSize { get => 256 * 1024; }