diff options
author | Casey Deccio <casey@deccio.net> | 2016-07-29 21:24:19 +0300 |
---|---|---|
committer | Casey Deccio <casey@deccio.net> | 2016-07-29 21:24:19 +0300 |
commit | 782a4f6391685eb6dec0491ddc4a353c6fea944a (patch) | |
tree | 5cfc64e6458aa32b6a6af5b86b34949f499ab4e3 | |
parent | a772d68095a8f870e6806018358e6341b943c76c (diff) |
Check for explicit delegation
Only assess NS records and corresponding address records if not
explicit delegation
-rw-r--r-- | dnsviz/analysis/offline.py | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/dnsviz/analysis/offline.py b/dnsviz/analysis/offline.py index 571e3c1..7a7ab4b 100644 --- a/dnsviz/analysis/offline.py +++ b/dnsviz/analysis/offline.py @@ -1443,18 +1443,13 @@ class OfflineDomainNameAnalysis(OnlineDomainNameAnalysis): if self.analysis_type != ANALYSIS_TYPE_AUTHORITATIVE: return + if self.explicit_delegation: + return + all_names = self.get_ns_names() names_from_child = self.get_ns_names_in_child() names_from_parent = self.get_ns_names_in_parent() - # With explicit delegations we won't have queried for authoritative NS - # records, but we also don't need to check delegation consistency in - # that case. - if (self.name, dns.rdatatype.NS) in self.queries: - auth_ns_response = self.queries[(self.name, dns.rdatatype.NS)].is_valid_complete_authoritative_response_any() - else: - auth_ns_response = False - glue_mapping = self.get_glue_ip_mapping() auth_mapping = self.get_auth_ns_ip_mapping() |