diff options
| author | wren romano <2998727+wrengr@users.noreply.github.com> | 2022-10-08 00:21:02 +0300 |
|---|---|---|
| committer | wren romano <2998727+wrengr@users.noreply.github.com> | 2022-10-12 00:03:37 +0300 |
| commit | 90fd13b0a1120a7fa50a21d4d46af61285b7a964 (patch) | |
| tree | d5fb328d1b37f08b4c1ce04620983b3ee0050624 /mlir/test/Dialect/SparseTensor/sparse_reshape.mlir | |
| parent | 1079662d2fff7ae799503d910b299c5108d105fd (diff) | |
[mlir][sparse] Converting SparseTensorCOO to use standard C++-style iterators.
This differential comprises three related changes: (1) it gives SparseTensorCOO standard C++-style iterators; (2) it removes the old iterator stuff from SparseTensorCOO; and (3) it introduces SparseTensorIterator which behaves like the old SparseTensorCOO iterator stuff used to.
The SparseTensorIterator class is needed because the MLIR codegen cannot easily use the C++-style iterators (hence why SparseTensorCOO had the old iterator stuff). Distinguishing SparseTensorIterator from SparseTensorCOO also helps improve API hygiene since these two classes are used for distinct purposes. And having SparseTensorIterator as its own class enables changing the underlying implementation in the future, without needing to worry about updating all the codegen tests etc.
Reviewed By: aartbik
Differential Revision: https://reviews.llvm.org/D135485
Diffstat (limited to 'mlir/test/Dialect/SparseTensor/sparse_reshape.mlir')
| -rw-r--r-- | mlir/test/Dialect/SparseTensor/sparse_reshape.mlir | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/mlir/test/Dialect/SparseTensor/sparse_reshape.mlir b/mlir/test/Dialect/SparseTensor/sparse_reshape.mlir index 420d732ce62a..83e022146f48 100644 --- a/mlir/test/Dialect/SparseTensor/sparse_reshape.mlir +++ b/mlir/test/Dialect/SparseTensor/sparse_reshape.mlir @@ -35,7 +35,7 @@ // CHECK-CONV: } // CHECK-CONV: %[[N:.*]] = call @newSparseTensor // CHECK-CONV: call @delSparseTensorCOOF64 -// CHECK-CONV: call @delSparseTensorCOOF64 +// CHECK-CONV: call @delSparseTensorIteratorF64 // CHECK-CONV: return %[[N]] : !llvm.ptr<i8> // // rewrite for codegen: @@ -97,7 +97,7 @@ func.func @sparse_expand(%arg0: tensor<100xf64, #SparseVector>) -> tensor<10x10x // CHECK-CONV: } // CHECK-CONV: %[[N:.*]] = call @newSparseTensor // CHECK-CONV: call @delSparseTensorCOOF64 -// CHECK-CONV: call @delSparseTensorCOOF64 +// CHECK-CONV: call @delSparseTensorIteratorF64 // CHECK-CONV: return %[[N]] : !llvm.ptr<i8> // // rewrite for codegen: @@ -172,7 +172,7 @@ func.func @sparse_collapse(%arg0: tensor<10x10xf64, #SparseMatrix>) -> tensor<10 // CHECK-CONV: } // CHECK-CONV: %[[N:.*]] = call @newSparseTensor // CHECK-CONV: call @delSparseTensorCOOF64 -// CHECK-CONV: call @delSparseTensorCOOF64 +// CHECK-CONV: call @delSparseTensorIteratorF64 // CHECK-CONV: return %[[N]] : !llvm.ptr<i8> // // rewrite for codegen: @@ -244,7 +244,7 @@ func.func @dynamic_sparse_expand(%arg0: tensor<?xf64, #SparseVector>) -> tensor< // CHECK-CONV: } // CHECK-CONV: %[[N:.*]] = call @newSparseTensor // CHECK-CONV: call @delSparseTensorCOOF64 -// CHECK-CONV: call @delSparseTensorCOOF64 +// CHECK-CONV: call @delSparseTensorIteratorF64 // CHECK-CONV: return %[[N]] : !llvm.ptr<i8> // // rewrite for codegen: |