| Age | Commit message (Collapse) | Author |
|---|
|
ThreadPoolTests.QueueRegisterPositiveAndFlowTest
Only observed a couple of time in CoreFX, corlib-xunit Windows x64 Mono CI,
https://jenkins.mono-project.com/view/Mono/job/z/label=w64/8715/testReport/junit/Test%20collection%20for%20System.Threading.ThreadPools.Tests/ThreadPoolTests/System_Threading_ThreadPools_Tests_ThreadPoolTests_QueueRegisterPositiveAndFlowTest/
Test is using a local variable to set state between threads and very infrequent,
the reading thread seems to pick the old value.
Looks like coordination between reader/writer thread works as expected and since
this is an infrequent failure, doesn't look like a coordination issues or problem
with the ThreadPool (would have expected failures in many tests) implementation.
The test is however using a fragile construction using a local variable (backgroundAsyncLocalValue)
to share state between the writer/reader thread without any synchronization involved.
That could lead to infrequent failures due to memory read/write optimizations.
Since this is a shared local variable captured and shared between main thread and thread pool
it needs to have proper acquire/release semantics, or it could cause failures like these due
to memory optimization.
|
|
|
|
8.0). (#246)
Bring some code from corefx master for async-streams (C# 8.0):
- `IAsyncEnumerable`
- `IAsyncEnumerator`
- `IAsyncDisposable`
- `AsyncIteratorStateMachineAttribute`
- `AsyncIteratorMethodBuilder`
- `ManualResetValueTaskSourceCore`
Minor changes to existing code:
- Add `ExecutionContext.ContextCallback<TState>(ref TState state)` delegate.
- Add `ExecutionContext.RunInternal<TState>` method.
|
|
* Build uapaot System.Numerics.Vectors
With `Vector<T>` now residing in System.Private.CoreLib, directly reference System.Private.Corelib instead of contracts just like netcoreapp does.
Add uapaot flavor since System.Private.CoreLib has a different strong name key on that platform.
* Make EnsureExtendedPrefixOverMaxPath available to UAP
Add the helper method `System.IO.PathInternal.EnsureExtendedPrefixOverMaxPath` to Common\src\System\IO\PathInternal.Windows.cs. It was previously not visible to UAP since Common\src\CoreLib\System\IO\PathInternal.Windows.cs is not included in UAP compilation.
* Keep SocketsHttpHandler out of UAP builds
SocketsHttpHandler is not supported in uap and is currently leaking into UAP builds since they've been disabled for a few weeks. Adjust the contract so it's not available to UAP, and clean the implementation assembly so SocketsHttpHandler internals don't leak out into HttpClientHandler.Core.cs.
* Fix GetAddrInfoExSupportsOverlapped UAP build break
`System.Net.NameResolutionPal.GetAddrInfoExSupportsOverlapped` uses LoadLibraryExW which is not compatible with UAP (which only supports LoadLibrary of DLLs within a container). Refactor the helper so UAP returns false.
* Revert "Disable UAP legs per #26802 (#26822)"
This reverts commit 120dce456a90df9982797d6c94eaaababd3e00d1.
* Revert "Disable UAP configurations in all configurations build"
This reverts commit 2202b4fd49ace58876763903f43cf27b2275c10a.
* Revert "Disable UAP official builds (#26871)"
This reverts commit ef79caf14cd922c8aa1a9aa280cbe503fdce26aa.
- Baseline the ApiCompat and GenFacades failures in System.Runtime.Extensions and System.Threading.ThreadPool.
- Adjust naming of files to match branch conventions
- Fix up some configuration issues with uap packaging. The CoreFX.Private.TestUtilities packaging needs updated build tools which can map between uwp6.0 and netstandard2.0.
- ifdef out Thread.GetCurrentProcessorId until we get a new System.Private.CoreLib.
|
|
|
|
|
|
* Add test for setting min worker threads in thread pool to 0
Related to https://github.com/dotnet/coreclr/issues/14239
Depends on https://github.com/dotnet/coreclr/pull/14864
* Add a verification removed in https://github.com/dotnet/corefx/pull/25144
* Address feedback
|
|
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono)] (#25113)
* skip some tests on mono
* mark more tests with SkipOnMono attribute
* Mark more tests with [SkipOnMono]
* remove SkipOnMono from SqlErrorCollectionTest
* add comments
|
|
|
|
UpdateVSConfigurations (#24752)
* Fixed odbc configurations for compat package
* Run UpdateVSConfigurations
* Remove Default Configurations to help VS... comment from csproj's
* Remove from System.Buffers as well
|
|
|
|
* Moving PlatformDetection to Corefx.Private.TestUtilities assembly
The purpose of this change is to clean up all test projects instead of including the PlatformDetection code inside every test project, we’ll have it in the Corefx.Private.TestUtilities.
I have refactored the PlatformDetection to split the different implementation of Windows and Linux. If we need to do more refactoring there we can do it later as needed.
* Fix Linux BB
* Update the xunit package reference
* Fix wrong condition on one of the tests
* Update the ConditionalFact/Theory to use Type as a parameter
|
|
a… (#21780)" (#22069)
This reverts commit 066ad32f1352fe5325998b997b93a0e0cb54cf58.
|
|
(#21780)
* Have the uap version of RemoteExecutorTestBase.RemoteInvoke wait in a background thread
Fixes #21275
* Fix build
* Address feedback
* Fix build
* Fix test
* Fix test
* Fix something
|
|
|
|
Fix ThreadPool tests for uapaot.
|
|
Many CSProjs included the comment
`<!-- Help VS understand available configurations -->`
These aren't handled well by the tooling that rewrites projects and weren't providing much value.
Remove them.
|
|
|
|
Add test for thread pool concurrent initialization
Depends on dotnet/coreclr#10869
Fixes dotnet/coreclr#10521
|
|
Now instead of Use*Key a project can instead define the assembly key
in the project (genreally the common dir.pops for a project) using
the AssemblyKey property. The accepted values are Open, ECMA, MSFT,
Test.
This change allows for a repo to set the default key they want to use
for projects. In corefx we have switched the default to use the Open
key instead of the old BuildTools default of MSFT key.
As part of this update we are explicitly setting the AssemblyKey in
all the library projects (although it is really only necessary for
projects that aren't the default).
Also with this change we are updating all the new libraries that have
not yet shipped stable (compared to our 1.1 release) and making them
use the Open key. Which means that for prerelease dependencies there
might be some binary breaking changes to consume.
The following libraries ahven't shipped so there key is being
changed from MSFT to Open:
Microsoft.XmlSerializer.Generator
System.CodeDom
System.Configuration.ConfigurationManager
System.Data.Odbc
System.DirectoryServices
System.DirectoryServices.AccountManagement
System.DirectoryServices.Protocols
System.IO.Ports
System.Json
System.Memory
System.Net.HttpListener
System.Net.Mail
System.Net.ServicePoint
System.Net.WebClient
System.Net.WebProxy
System.Private.Xml
System.Private.Xml.Linq
System.Security.Cryptography.Xml
System.Security.Permissions
System.Transactions.Local
System.Web.HttpUtility
|
|
|
|
* Enable tests to compile with netstandard
Most of the tests have netstandard configurations and it doesn't compile. the changes here is to fix the configurations and the tests to compile.
This is important step to get netfx tests compile too as we are in most of the time netfx fallback to netstandard configuration
The changes include some fixes to compile teh sources too.
* Fix System.Collections.Immutable
* update src configuration
* remove netstandard17 defines
* Split netcoreapp code to its own files
* Remove 17 from the test class name
|
|
Prepare uap package
|
|
|
|
|
|
Make sure that we represent System.PrivateCoreLib as OSGroup specific
since it exposes different types on Windows vs Unix.
|
|
|
|
BuildConfigurations
|
|
Remove all cruft from projects related to building desktop configs which
now build in standard repo.
|
|
Exceptions for types missing from netstandard facade:
- System.Data.Common - DbColumn, DbDataReaderExtensions, IDbColumnSchemaGenerator
- System.Diagnostics.StackTrace - StackFrameExtensions
- System.Numerics.Vectors - Vector, Vector<T>
- System.Runtime.Serialization.Primitives - ISerializationSurrogateProvider
- System.Runtime.Serialization.Xml - DataContractSerializerExtensions
- System.Security.Cryptography.Cng - AesCng, TripleDESCng <link>
- System.Threading.Overlapped - PreAllocatedOverlapped, ThreadPoolBoundHandle
- System.Xml.XPath.XDocument - XDocumentExtensions
|
|
|
|
(#15373)
Removing netstandard configurations for things that are bellow netstandard
|
|
Removing System.Private.CoreLib from TargetingPack
|
|
(#15291)
Adding missing Configurations.props for refs and fixing the existing ones
|
|
Related to https://github.com/dotnet/corefx/commit/0797813bfe3a9e6d04d4bfaa865b477bb26f8ce2
This removes packages where the types have been moved into
netstandard.dll in netstandard2.0.
These types are supported as follows:
1. In a netstandard2.0+ project via NETStandard.Library package's
netstandard.dll
2. In a netstandard1.x project via contract assembly packages which
ship from servicing branches.
3. In a framework specific project via the framework's targeting pack
or framework package.
|
|
* Add ValidateVSConfigurations
* Update project config and sln files.
|
|
|
|
Sorting and trimming Reference items in csprojs
|
|
|
|
|
|
beta-24904-00, respectively
|
|
build.proj (#14663)
* [WIP]Created src\tests.proj which is mostly building all tests
* Convert test project .builds to Configuration.props
* Fix test paths in targetingpack.props, move test-runtime.
* Move test-runtime under external.
* Rename RuntimeDir->RuntimePath in targetingpacks.props and
Xunit.Runtime.depproj.
* Remove test-runtime project.json from the SupplementalTestData list in
dir.targets.
* Remove XUnit.Runtime.depproj from tests.proj
* Convert test .builds files to Configuration.props.
* Revert "Convert test project .builds to Configuration.props"
This reverts commit 1efc4d9a02d1c2eced0f20a544abcbcd0092f40c.
* Fix compilation error in System.Collections.Concurrent.Tests
* Fix condition in System.Collections ref project
* Fix two more Collections test project issues
* Add Configuration.props for System.Collections ref
* Fix TargetGroup conditions in System.Collections.Tests.csproj.
* Fix compilation problems with NameResoltion.Pal.Tests.
* Fix compilation errors in SqlClient Stress tests
* Fix IO.Compression.Performance tests compilation
* Fix compilation and configurations of System.Net.Http.Unit.Tests.csproj.
* Fix compilation issues in System.Private.Xml.Linq tests
* Disable XsltScenarios.Tests project, like it was before.
* Fix missing DefineConstants for System.Linq ref project.
* Fix compilation of System.Net.Primitives.Pal.Tests.csproj
* Fix compilation of System.Net.Primitives.UnitTests.Tests.csproj
* Fix compilation of System.Security.Cryptography.Cng.Tests.csproj.
* Fix compilation of System.Net.Primitives reference project
* Fix compilation of System.Net.Security ref project
* Fix compilation of SYstem.Net.Security.Tests.csproj
* Fix configuration of X509Certificates ref project
* Fix compilation errors in System.Net.Http.Unit.Tests.csproj
* Fix Common.Tests.csproj
* Fix System.Diagnostics.Debug.Tests.csproj
* Fix Microsoft.Win32.Registry.Tests.csproj
* Add runtime.native.System.Data.SqlClient.sni to external project
* Fix System.Diagnostics.TraceSource.Tests.csproj
* Fix System.IO.Compression.Performance.Tests.csproj
* Move supplemental test data into test-runtime/project.json
* Fix System.IO.FileSystem.Watcher.Tests.csproj
* Fix System.IO.FileSystem.Tests.csproj
* Fix System.IO.Pipes.AccessControl.Tests.csproj
* Fix System.IO.MemoryMappedFiles.Tests.csproj
* Fix System.IO.Pipes.Tests.csproj
* Fix System.Json.Tests.csproj
* Add missing supplemental test data for net security tests
* Fix resource names in System.Xml.XPath.XDocument.Tests.csproj
* Fix Assembly.Location test case
* Fix assembly loading paths in DefaultLoadContextTest.cs
* Fix issues in System.Runtime.Loader.Tests.csproj
* Fix RootNamespace in ResourceManager tests
* Mark OpenSSL tests as unsupported on Windows
* Fix RootNamespace in System.Xml.XPath.Tests.csproj
* Fix RootNamespace in System.Xml.XPath.XmlDocument.Tests.csproj
* Fix System.IO.Compression.Tests.csproj
* Add missing Configurations.props files for System.Net projects
* Fix compilation issues in WinHttpHandler tests
* Add fixes and a workaround for Linq.Expressions tests
* Add workaround for System.Runtime.Tests
* Use extension methods explicitly in Ref.Emit tests
* Hook up test projects into build
* Fix build configuration of Crypto.Primitives for netcoreapp
* Enable VB tests outside Windows
* Enable Mail tests outside windows
* Don't run Unsafe tests outside windows
* Don't build Unsafe tests outside Windows
* Don't build WebServer project outside of Windows.
* Fix corerun path for Unix tests.
* Fix casing of 'Native' directory in NETCoreApp private pkgproj
* Remove runtime-specific stuff from Xunit.Runtime.depproj
* Move tests into a separate project ('tests.msbuild') which isn't built in build.proj
* Remove duplicate types from NameResolution.Pal tests
* Skip tests in a project if there is no compatible configuration.
* Include internal socket types only on Windows in NameResolution tests
* Manually fix S.R.InteropServices configurations
* Rename tests.msbuild -> tests.builds
* Manually fix System.Text.Encoding.Tests.csproj configuration
* Manually fix System.Threading.Tests configuration
* Manually clean up System.Runtime.Tests.csproj
* Fix System.IO.FileSystem.Tests configurations
* Manually fix System.Globalization.Tests configurations
* Manually fix System.IO.Pipes.Tests configurations
* Manually fix System.IO.Compression.Tests configurations
* Manually fix System.Runtime.Extensions.Tests configurations
* Manually fix System.IO.MemoryMappedFiles.Tests configurations
* Manually fix S.Diagnostics.Process.Tests configurations
* Manually fix System.ComponentModel.TypeConverter.Tests configurations
* Misc PR feedback.
* Use HostRunnerName instead of HostRunner in Process tests
* Fix configurations for S.ServiceProcess.ServiceController.Tests
* Revert to using ConfigurationErrorMsg to check if tests should be skipped.
Configuration still defaults to 'Debug' even if there is no valid configuration.
|
|
|
|
beta-24903-00, respectively
|
|
|
|
|
|
beta-24902-00, respectively
|
|
beta-24829-00, respectively (#14755)
|
|
beta-24828-00, respectively (#14743)
|
|
beta-24827-00, respectively
|
