diff options
| author | Stefan Niedermann <info@niedermann.it> | 2022-08-11 10:47:18 +0300 |
|---|---|---|
| committer | Stefan Niedermann <info@niedermann.it> | 2022-08-11 10:49:52 +0300 |
| commit | fcebf67c03e4357b702c316b6376d711332db975 (patch) | |
| tree | 1d3b951293c59a58f8a859d646b09f66b773ecd3 | |
| parent | 7f5842ced8cfb876d6b62868be8bfc80920a2962 (diff) | |
🐞 Fix #1541 Favorite star in menu not clickable
Signed-off-by: Stefan Niedermann <info@niedermann.it>
| -rw-r--r-- | app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java | 3 | ||||
| -rw-r--r-- | fastlane/metadata/android/en-US/changelogs/3005001.txt | 1 |
2 files changed, 3 insertions, 1 deletions
diff --git a/app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java b/app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java index 06953006..2683d8f0 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java +++ b/app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java @@ -201,7 +201,7 @@ public abstract class BaseNoteFragment extends BrandedFragment implements Catego } private void prepareFavoriteOption(MenuItem item) { - item.setIcon(TRUE.equals(note.getFavorite()) ? R.drawable.ic_star_white_24dp : R.drawable.ic_star_border_white_24dp); + item.setIcon(note.getFavorite() ? R.drawable.ic_star_white_24dp : R.drawable.ic_star_border_white_24dp); item.setChecked(note.getFavorite()); tintMenuIcon(item, colorAccent); } @@ -227,6 +227,7 @@ public abstract class BaseNoteFragment extends BrandedFragment implements Catego listener.close(); return true; } else if (itemId == R.id.menu_favorite) { + note.setFavorite(!note.getFavorite()); repo.toggleFavoriteAndSync(localAccount, note.getId()); listener.onNoteUpdated(note); prepareFavoriteOption(item); diff --git a/fastlane/metadata/android/en-US/changelogs/3005001.txt b/fastlane/metadata/android/en-US/changelogs/3005001.txt index 44629770..3aac5ff6 100644 --- a/fastlane/metadata/android/en-US/changelogs/3005001.txt +++ b/fastlane/metadata/android/en-US/changelogs/3005001.txt @@ -1,4 +1,5 @@ - 📱️ Add option to not keep screen on (#1531) +- 🐞 Favorite star in menu not clickable (#1541) - ⚙️ Add monochrome icon (#1544) - by @salixor - ⚙️ Use the new Android 12 SplashScreen API (#1546) - by @salixor - 🌎 Updated translations
\ No newline at end of file |