| Age | Commit message (Collapse) | Author |
|---|
|
This PR makes all changes necessary to use unity builds for Mumble.
On my Linux machine this effectively halves the compilation time.
This PR also enables unity builds on all CI runs.
|
|
There is some preprocessor magic going on for the DEFINE_GUID macro that
causes it to only declare an extern variable (instead of defining and
initializing and actual variable) unless the initguid.h header was used.
The latter is done in WinGUIDs.cpp in order to really initialize the
variables somewhere whereas everywhere else (namely WASAPI.cpp) only
references these extern variables.
|
|
The *_plugin_import files will cause collisions in a unity build, so we
have to make sure that they are built separately as usual.
Furthermore the ObjecticeC files don't play well in unity builds (it
seems like they are then treated as cpp files). Thus they are excluded
from that as well.
WinGUID.cpp must also not be included as that breaks the DEFINE_GUID
macro wizardry needed to avoid redefinition errors.
|
|
This commit explicitly excludes certain targets from being built in a
unity build (or rather they continue to get built normally) as they
cause compilation errors in these kind of builds.
|
|
This is needed in order for the <cmath> header to also define constants
like M_PI. Instead of manually defining the macro every time before
including <cmath>, the macro is now defined via cmake and thus always
defined.
|
|
There was a function for processing QsslStrings in UserInformation.cpp
as well as ViewCert.cpp. These functions were completely identical.
Therefore there were name clashes that appeared when performing a unity
build.
Furthermore duplicating functionality in multiple places in never a good
idea. Thus this commit refactors the code so that both classes now use a
shared implementation in QtUtils.cpp.
|
|
|
|
When performing a unity build the usage of the variable name "registrar"
in a bunch of places for a static variable, can cause name clashes. Thus
the different variables where renamed.
|
|
|
|
If they are not there is the potential of name clashes when performing a
unity build.
See: https://stackoverflow.com/questions/847974/the-benefits-disadvantages-of-unity-builds
|
|
Defining a macro (global namespace) named "g" as a shortcut for
accessing the Global struct never was a good idea. In order to avoid the
problems this created (you must never name a variable "g" or include
Global.h before a header that may have such a variable), the macro was
removed and was instead replaced with a static function Global::get()
that returns a reference to the Global struct.
Just as with the old g macro, the existence of the respective pointer is
not explicitly checked before dereferencing. It is assumed that
everywhere where it is used, the Global struct has already been created.
|
|
Translation: Mumble/Mumble Client
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble/nb_NO/
|
|
Translation: Mumble/Mumble Client
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble/de/
|
|
|
|
Currently translated at 99.0% (1936 of 1954 strings)
Co-authored-by: ayiniho <ayiniho@tedomum.net>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/fr/
Translation: Mumble/Mumble Client
|
|
Currently translated at 96.2% (1881 of 1954 strings)
Co-authored-by: Remi Rampin <remi@rampin.org>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/fr/
Translation: Mumble/Mumble Client
|
|
Currently translated at 81.0% (1583 of 1954 strings)
Co-authored-by: Kristoffer Grundström <swedishsailfishosuser@tutanota.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/sv/
Translation: Mumble/Mumble Client
|
|
Currently translated at 91.5% (1789 of 1954 strings)
Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/nb_NO/
Translation: Mumble/Mumble Client
|
|
Currently translated at 78.8% (1541 of 1954 strings)
Co-authored-by: ViBE <vibe@protonmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/hu/
Translation: Mumble/Mumble Client
|
|
Currently translated at 100.0% (1954 of 1954 strings)
Co-authored-by: deluxghost <deluxghost@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/zh_Hans/
Translation: Mumble/Mumble Client
|
|
Currently translated at 76.1% (1487 of 1954 strings)
Co-authored-by: ViBE <shouldn_t@msn.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/hu/
Translation: Mumble/Mumble Client
|
|
Currently translated at 96.9% (1894 of 1954 strings)
Co-authored-by: inesre <inesre21@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/es/
Translation: Mumble/Mumble Client
|
|
Currently translated at 98.0% (1915 of 1954 strings)
Co-authored-by: Elias Meyer <elektrovirus@protonmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/fi/
Translation: Mumble/Mumble Client
|
|
Currently translated at 97.2% (1900 of 1954 strings)
Co-authored-by: Translator <weblate.gledy@aleeas.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/de/
Translation: Mumble/Mumble Client
|
|
Currently translated at 98.8% (1931 of 1954 strings)
Co-authored-by: Nikita Epifanov <nikgreens@protonmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/ru/
Translation: Mumble/Mumble Client
|
|
Currently translated at 97.9% (1914 of 1954 strings)
Co-authored-by: Artem <KovalevArtem.ru@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/ru/
Translation: Mumble/Mumble Client
|
|
Currently translated at 100.0% (1954 of 1954 strings)
Co-authored-by: Gert-dev <dr9xsj+78ciu0bq6jh18@sharklasers.com>
Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/nl/
Translation: Mumble/Mumble Client
|
|
|
|
The source text changed, dropping the 'for gamers' subheadline part.
This small change effectively dropped the translation where it could have been preserved but marked as outdated.
Manually fix up the Mumble headline + subheadline source string and translation.
Take over the old translation, but mark it as unfinished.
This way we have a decent but outdated translation (that still mentions 'for gamers' in the subheadline).
|
|
Manually recover translations from previous file versions.
To recover them the old files are used, moving the elements to their new location within the xml element,
and manually fixing up the changed Connect element; keep the translation but mark them unfinished.
This way we have a decent but outdated translation rather than none.
|
|
Remove unexpected newlines. These can’t be right.
|
|
|
|
This reverts commit 591741c9a6588107431f68e81f34ad64af65d0fd
which was part of PR #4777.
That change switched `tr` calls from the specific class to being referenced on QObject.
That broke all of the translations we have for these strings.
Qt/tr assigns a translation context, which is the Q_OBJECT context by default. By not calling tr on the specific QObject but the base function, the context is dropped. The strings are now no longer in the ConnectDialog but the generic QObject.
Obviously that is undesired.
Reverting that change is the first step to manually restoring the translations.
They were dropped automatically by updating translations - and the previous strings no longer existing.
|
|
|
|
|
|
Note: The lupdate script noted the removal of plural forms as the target language has less forms for:
br, cs, en, fa_IR, he, hu, lt, pl, ru, tr, uk
The printed message is:
> Removed plural forms as the target language has less forms.
> If this sounds wrong, possibly the target language is not set or recognized.
|
|
On macOS, it is observed that Ctrl-C terminates murmur abruptly
without a graceful shutdown. And the UDP port it used just keeps
being occupied even after murmur is terminated.
This fix sets up signal handlers to ensure a graceful shutdown
before quitting.
|
|
This allows server admins to explicitly trigger the broadcast of the
currently set welcome text to a given set of users.
By first setting a new welcome text and then broadcasting it to all
currently connected users, the old behavior of setting the welcome
message (changed in da26386) can be
restored.
Fixes #4805
|
|
add to user count
This commit fixes both issues discussed in #4277 which were related to
the fact that any socket connection was allocated an ID and marked as
a user. This bug allowed for a malicious user to lock out all users of
a server regardless of server password usage. This change simply moves ID
allocation to after a connection is marked as Authenticated.
FIXES: #4277
|
|
This allows server admins to explicitly trigger the broadcast of the
currently set welcome text to a given set of users.
By first setting a new welcome text and then broadcasting it to all
currently connected users, the old behavior of setting the welcome
message (changed in da26386827a5802cfc82ce45cb8b30469e83d73f) can be
restored.
Fixes #4805
|
|
This PR updates the copyright notices of all files. For doing so
it introduces a script that can do this automatically.
Furthermore a few files that are no longer needed got removed.
|
|
This commit fixes both issues discussed in #4277 which were related to
the fact that any socket connection was allocated an ID and marked as
a user. This bug allowed for a malicious user to lock out all users of
a server regardless of server password usage. This change simply moves ID
allocation to after a connection is marked as Authenticated.
FIXES: #4277
|
|
The name of `SAVELOAD` is confusing. I assume using `SAVELOAD` and
redefining `SAVELOAD` in the middle of Settings.cpp is just to make
copying LOAD part into SAVE part works without modifications...
However, now the logic of saving and loading are becoming more and
more complicated, and simply copying and pasting won't work anymore.
Therefore there's no good reason to keep using this confusing
`SAVELOAD` instead of `SAVE` and `LOAD` now.
|
|
Some USB audio interfaces have both input and output stream,
but they are accidentally ignored in #4694.
|
|
This was done by running scripts/updateLicenseHeaders.py and then
manually editing the LICENSE file.
|
|
The project was switched from qmake pro projects which include pri files to CMake.
No pro or pri files exist anymore, and this file should not either.
It is obsolete and unused.
|
|
when changing via Ice
When changing the welcome text via Ice, Murmur would broadcast the new text to all connected clients. It is a matter of opinion if this is proper behavior or not, but it seems too proactive of an action. Let the clients see the new welcometext when they next connect, or let the Murmur administrator explicitly perfor a sendMessage() to all connected clients after changing the welcometext.
Closes: #4788
|
|
Previously, the un-encoded array length was used to construct a string
from the encoded byte array, resulting in truncated base64.
|
|
When changing the welcome text via Ice, Murmur would broadcast the new text to all connected clients. It is a matter of opinion if this is proper behavior or not, but it seems too proactive of an action. Let the clients see the new welcometext when they next connect, or let the Murmur administrator explicitly perfor a sendMessage() to all connected clients after changing the welcometext.
Closes: #4788
Co-Authored-By: Robert Adam <dev@robert-adam.de> <krzmbrzl@gmail.com>
Co-Authored-By: Robert Adam <dev@robert-adam.de> <krzmbrzl@users.noreply.github.com>
|
|
OSInfo::getOSDisplayableVersion()
4fc7df5ddeb2a52cafdd67cbc0b0d3182f14cfdb removed the code that needed "_SYSTEM_INFO".
|
